Clippy lints / Pedantic
Clippy lint · Pedantic · checked with Clippy 0.1.99
clippy::enum_glob_use: Checks for use Enum::*
What it meansChecks for use Enum::*. It is in the pedantic group and off by default.
Does it matter?
It is usually better style to use the prefixed name of an enumeration variant, rather than importing variants.
Stricter lints with some false positives. Off by default; opt in with clippy::pedantic.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
use std::cmp::Ordering::*;
foo(Less);
Write this instead
use std::cmp::Ordering;
foo(Ordering::Less)
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
enum_glob_use = "warn"In code
#![warn(clippy::enum_glob_use)]One run
cargo clippy -- -W clippy::enum-glob-useThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for use Enum::*.
Why is this bad?
It is usually better style to use the prefixed name of an enumeration variant, rather than importing variants.
Known problems
Old-style enumerations that prefix the variants are still around.
Example
use std::cmp::Ordering::*;
foo(Less);
Use instead:
use std::cmp::Ordering;
foo(Ordering::Less)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_linesChecks for functions with a large amount of lines
- missing_errors_docChecks the doc comments of publicly visible functions that return a Result type and warns if there is no # Errors section
- must_use_candidateChecks for public functions that have no #[must_use] attribute, but return something not already marked must-use, have no mutable arg and mutate no statics
- doc_markdownitem in documentation is missing backticks
- duration_suboptimal_unitsconstructing a `Duration` using a smaller unit when a larger unit would be more readable
- elidable_lifetime_namesChecks for lifetime annotations which can be replaced with anonymous lifetimes ('_)
- expl_impl_clone_on_copyChecks for explicit Clone implementations for Copy types
- explicit_deref_methodsexplicit `deref` method call
- explicit_into_iter_loopChecks for loops on y.into_iter() where y will do, and suggests the latter
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_linesChecks for functions with a large amount of linesRead it next →Did this answer your question?