Clippy lints / Pedantic
Clippy lint · Pedantic · checked with Clippy 0.1.99
clippy::manual_bit_width: manual implementation of `bit_width`
What it meansChecks for usage of T::BITS - x.leading_zeros() when x.bit_width() is available. It is in the pedantic group and off by default.
What you see
warning: manual implementation of `bit_width` --> main.rs:4:17 | 4 | let bit_width = u32::BITS - x.leading_zeros(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_bit_width = note: `-W clippy::manual-bit-width` implied by `-W clippy::pedantic` help: try | 4 - let bit_width = u32::BITS - x.leading_zeros(); 4 + let bit_width = x.bit_width(); |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Manual reimplementations of bit_width increase code complexity for little benefit.
Stricter lints with some false positives. Off by default; opt in with clippy::pedantic.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let x: u32 = 5;
let bit_width = u32::BITS - x.leading_zeros();
Write this instead
let x: u32 = 5;
let bit_width = x.bit_width();
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
manual_bit_width = "warn"In code
#![warn(clippy::manual_bit_width)]One run
cargo clippy -- -W clippy::manual-bit-widthThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of T::BITS - x.leading_zeros() when x.bit_width() is available.
Why is this bad?
Manual reimplementations of bit_width increase code complexity for little benefit.
Example
let x: u32 = 5;
let bit_width = u32::BITS - x.leading_zeros();
Use instead:
let x: u32 = 5;
let bit_width = x.bit_width();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_linesChecks for functions with a large amount of lines
- missing_errors_docChecks the doc comments of publicly visible functions that return a Result type and warns if there is no # Errors section
- must_use_candidateChecks for public functions that have no #[must_use] attribute, but return something not already marked must-use, have no mutable arg and mutate no statics
- macro_use_importsChecks for #[macro_use] use
- manual_assertonly a `panic!` in `if`-then statement
- manual_assert_eqused `assert!` with an equality comparison
- manual_ilog2manually reimplementing `ilog2`
- manual_instant_elapsedmanual implementation of `Instant::elapsed`
- manual_is_power_of_twomanually reimplementing `is_power_of_two`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_linesChecks for functions with a large amount of linesRead it next →Did this answer your question?