Clippy lints / Restriction
Clippy lint · Restriction · checked with Clippy 0.1.99
clippy::modulo_arithmetic: you are using modulo operator on constants with different signs: `-17 % 3`
What it meansChecks for modulo arithmetic. It is in the restriction group and off by default.
What you see
warning: you are using modulo operator on constants with different signs: `-17 % 3` --> main.rs:3:9 | 3 | let x = -17 % 3; | ^^^^^^^ | = note: double check for expected result especially when interoperating with different languages = note: or consider using `rem_euclid` or similar function = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#modulo_arithmetic = note: requested on the command line with `-W clippy::modulo-arithmetic`
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
The results of modulo (%) operation might differ depending on the language, when negative numbers are involved. If you interop with different languages it might be beneficial to double check all places that use modulo arithmetic. For example, in Rust 17 % -3 = 2, but in Python 17 % -3 = -1.
Lints that forbid language features for specific codebases (no unwrap, no indexing...). Off by default; pick them one by one, never the whole group.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
let x = -17 % 3;
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
modulo_arithmetic = "warn"In code
#![warn(clippy::modulo_arithmetic)]One run
cargo clippy -- -W clippy::modulo-arithmeticThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
allow-comparison-to-zero: Don’t lint when comparing the result of a modulo operation to zero.
Clippy's own documentation
What it does
Checks for modulo arithmetic.
Why restrict this?
The results of modulo (%) operation might differ
depending on the language, when negative numbers are involved.
If you interop with different languages it might be beneficial
to double check all places that use modulo arithmetic.
For example, in Rust 17 % -3 = 2, but in Python 17 % -3 = -1.
Example
let x = -17 % 3;
Configuration
-
allow-comparison-to-zero: Don’t lint when comparing the result of a modulo operation to zero.(default:
true)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- unwrap_usedChecks for .unwrap() or .unwrap_err() calls on Results and .unwrap() call on Options
- module_name_repetitionsDetects public item names that are prefixed or suffixed by the containing public module’s name
- expect_usedChecks for .expect() or .expect_err() calls on Results and .expect() call on Options
- mixed_read_write_in_expressionunsequenced read of `x`
- mod_module_filesChecks that module layout uses only self named module files; bans mod.rs files
- multiple_inherent_implmultiple implementations of this structure
- multiple_unsafe_ops_per_blockthis `unsafe` block contains 2 unsafe operations, expected only one
- mutex_atomicChecks for usage of Mutex<X> where an atomic will do
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::unwrap_usedChecks for .unwrap() or .unwrap_err() calls on Results and .unwrap() call on OptionsRead it next →Did this answer your question?