Clippy lint · Pedantic · checked with Clippy 0.1.99

clippy::redundant_else: redundant else block

What it meansChecks for else blocks that can be removed without changing semantics. It is in the pedantic group and off by default.

What you see

warning: redundant else block
 --> main.rs:7:6
  |
7 |       } else {
  |  ______^
8 | |         print!("Moving on...");
9 | |     }
  | |_____^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#redundant_else
  = note: `-W clippy::redundant-else` implied by `-W clippy::pedantic`
help: remove the `else` block and move the contents out
  |
7 ~     }
8 +     print!("Moving on...");
  |

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

The else block adds unnecessary indentation and verbosity.

Stricter lints with some false positives. Off by default; opt in with clippy::pedantic.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

fn my_func(count: u32) {
    if count == 0 {
        print!("Nothing to do");
        return;
    } else {
        print!("Moving on...");
    }
}

Write this instead

fn my_func(count: u32) {
    if count == 0 {
        print!("Nothing to do");
        return;
    }
    print!("Moving on...");
}

Turn it off, or on

It is off by default. To use it, set it to warn or deny:

Whole crate (Cargo.toml)

[lints.clippy]
redundant_else = "warn"

In code

#![warn(clippy::redundant_else)]

One run

cargo clippy -- -W clippy::redundant-else

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Pedanticgroup

allowdefault level

yesfixed by cargo clippy --fix

1.50.0added in Rust

Clippy's own documentation

What it does

Checks for else blocks that can be removed without changing semantics.

Why is this bad?

The else block adds unnecessary indentation and verbosity.

Known problems

Some may prefer to keep the else block for clarity.

Example

fn my_func(count: u32) {
    if count == 0 {
        print!("Nothing to do");
        return;
    } else {
        print!("Moving on...");
    }
}

Use instead:

fn my_func(count: u32) {
    if count == 0 {
        print!("Nothing to do");
        return;
    }
    print!("Moving on...");
}

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Up next

Also worth your time

Did this answer your question?