Clippy lints / Correctness
Clippy lint · Correctness · checked with Clippy 0.1.99
clippy::reversed_empty_ranges: this range is empty so it will yield no values
What it meansChecks for range expressions x..y where both x and y are constant and x is greater to y. Also triggers if x is equal to y when they are conditions to a for loop. It is in the correctness group and denied by default (the build fails).
What you see
error: this range is empty so it will yield no values --> main.rs:2:6 | 2 | (10..=0).for_each(|x| println!("{}", x)); | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#reversed_empty_ranges = note: `#[deny(clippy::reversed_empty_ranges)]` on by default help: consider using the following if you are attempting to iterate over this range in reverse | 2 - (10..=0).for_each(|x| println!("{}", x)); 2 + ((0..=10).rev()).for_each(|x| println!("{}", x)); |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Empty ranges yield no values so iterating them is a no-op. Moreover, trying to use a reversed range to index a slice will panic at run-time.
Code that is almost certainly wrong. Denied by default: the build fails until you fix it or allow it.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
fn main() {
(10..=0).for_each(|x| println!("{}", x));
let arr = [1, 2, 3, 4, 5];
let sub = &arr[3..1];
}
Write this instead
fn main() {
(0..=10).rev().for_each(|x| println!("{}", x));
let arr = [1, 2, 3, 4, 5];
let sub = &arr[1..3];
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::reversed_empty_ranges)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
reversed_empty_ranges = "allow"One run
cargo clippy -- -A clippy::reversed-empty-rangesThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for range expressions x..y where both x and y
are constant and x is greater to y. Also triggers if x is equal to y when they are conditions to a for loop.
Why is this bad?
Empty ranges yield no values so iterating them is a no-op. Moreover, trying to use a reversed range to index a slice will panic at run-time.
Example
fn main() {
(10..=0).for_each(|x| println!("{}", x));
let arr = [1, 2, 3, 4, 5];
let sub = &arr[3..1];
}
Use instead:
fn main() {
(0..=10).rev().for_each(|x| println!("{}", x));
let arr = [1, 2, 3, 4, 5];
let sub = &arr[1..3];
}
Past names
- reverse_range_loop
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- read_line_without_trimcalling `.parse()` on a string without trimming the trailing newline character
- recursive_format_implusing `self.to_string` in `fmt::Display` implementation will cause infinite recursion
- redundant_comparisonsChecks for ineffective double comparisons against constants
- self_assignmentself-assignment of `a.x` to `a.x`
- serde_api_misuseChecks for misuses of the serde API
- size_of_in_element_countDetects expressions where size_of::<T> or size_of_val::<T> is used as a count of elements of type T
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::read_line_without_trimcalling `.parse()` on a string without trimming the trailing newline characterRead it next →Did this answer your question?