Email me

Clippy lints / Restriction

Clippy lint · Restriction · checked with Clippy 0.1.99

clippy::shadow_reuse: `x` is shadowed

What it meansChecks for bindings that shadow other bindings already in scope, while reusing the original value. It is in the restriction group and off by default.

What you see

warning: `x` is shadowed
 --> main.rs:4:5
  |
4 | let x = x + 1;
  |     ^
  |
note: previous binding is here
 --> main.rs:3:5
  |
3 | let x = 2;
  |     ^
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#shadow_reuse
  = note: requested on the command line with `-W clippy::shadow-reuse`

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

Some argue that name shadowing like this hurts readability, because a value may be bound to different things depending on position in the code. See also shadow_same and shadow_unrelated for other restrictions on shadowing.

Lints that forbid language features for specific codebases (no unwrap, no indexing...). Off by default; pick them one by one, never the whole group.

How to fix it

Clippy does not fix this one automatically. Change the code by hand:

Flagged

let x = 2;
let x = x + 1;

Write this instead

let x = 2;
let y = x + 1;

Turn it off, or on

It is off by default. To use it, set it to warn or deny:

Whole crate (Cargo.toml)

[lints.clippy]
shadow_reuse = "warn"

In code

#![warn(clippy::shadow_reuse)]

One run

cargo clippy -- -W clippy::shadow-reuse

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Restrictiongroup
allowdefault level
nofixed by cargo clippy --fix
pre 1.29.0added in Rust

Clippy's own documentation

What it does

Checks for bindings that shadow other bindings already in scope, while reusing the original value.

Why restrict this?

Some argue that name shadowing like this hurts readability, because a value may be bound to different things depending on position in the code.

See also shadow_same and shadow_unrelated for other restrictions on shadowing.

Example

let x = 2;
let x = x + 1;

use different variable name:

let x = 2;
let y = x + 1;

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Related lints

All 847 Clippy lints · Rust compiler errors · Cargo.toml checker

Up next

Related lintclippy::unwrap_usedChecks for .unwrap() or .unwrap_err() calls on Results and .unwrap() call on OptionsRead it next →

Did this answer your question?

Get the receipts by email.

What my AI agents tried this week, with the real numbers: what worked, what flopped, what made money. One email when there is something worth reading.

No spam, never sold. Every email has a one-click unsubscribe.

Popular in the shop

All 124 tools →

Browse: Bundles and kitsHome, family and schoolMoney and businessAI toolsSports and fitnessMaking and hobbiesFood and drinkIndie dev and launchTrading and quant

Free: Landing page teardown iPhone app cost calculator LLM API cost calculator Paid online: $49 Launch Check App builds Articles FAQ