Clippy lints / Pedantic
Clippy lint · Pedantic · checked with Clippy 0.1.99
clippy::str_split_at_newline: Checks for usages of str.trim().split("\n") and str.trim().split("\r\n")
What it meansChecks for usages of str.trim().split("\n") and str.trim().split("\r\n"). It is in the pedantic group and off by default.
Does it matter?
Hard-coding the line endings makes the code less compatible. str.lines should be used instead.
Stricter lints with some false positives. Off by default; opt in with clippy::pedantic.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
"some\ntext\nwith\nnewlines\n".trim().split('\n');
Write this instead
"some\ntext\nwith\nnewlines\n".lines();
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
str_split_at_newline = "warn"In code
#![warn(clippy::str_split_at_newline)]One run
cargo clippy -- -W clippy::str-split-at-newlineThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usages of str.trim().split("\n") and str.trim().split("\r\n").
Why is this bad?
Hard-coding the line endings makes the code less compatible. str.lines should be used instead.
Example
"some\ntext\nwith\nnewlines\n".trim().split('\n');
Use instead:
"some\ntext\nwith\nnewlines\n".lines();
Known Problems
This lint cannot detect if the split is intentionally restricted to a single type of newline ("\n" or
"\r\n"), for example during the parsing of a specific file format in which precisely one newline type is
valid.
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_linesChecks for functions with a large amount of lines
- missing_errors_docChecks the doc comments of publicly visible functions that return a Result type and warns if there is no # Errors section
- must_use_candidateChecks for public functions that have no #[must_use] attribute, but return something not already marked must-use, have no mutable arg and mutate no statics
- single_char_patternChecks for string methods that receive a single-character str as an argument, e.g., _.split("x")
- single_match_elseChecks for matches with two arms where an if let else will usually suffice
- stable_sort_primitiveused `sort` on primitive type `i32`
- string_add_assignyou assigned the result of adding something to this string. Consider using `String::push_str()` instead
- struct_excessive_boolsChecks for excessive use of bools in structs
- struct_field_namesfield name starts with the struct's name
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_linesChecks for functions with a large amount of linesRead it next →Did this answer your question?