Clippy lint · Suspicious · checked with Clippy 0.1.99

clippy::suspicious_unary_op_formatting: by not having a space between `&&` and `!` it looks like `&&!` is a single operator

What it meansChecks the formatting of a unary operator on the right hand side of a binary operator. It lints if there is no space between the binary and unary operators, but there is a space between the unary and its operand. It is in the suspicious group and warns by default.

What you see

warning: by not having a space between `&&` and `!` it looks like `&&!` is a single operator
 --> main.rs:4:7
  |
4 | if foo &&! bar {}
  |       ^^^^^
  |
  = help: put a space between `&&` and `!` and remove the space after `!`
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#suspicious_unary_op_formatting
  = note: `#[warn(clippy::suspicious_unary_op_formatting)]` on by default

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

This is either a typo in the binary operator or confusing.

Code that is most likely wrong or useless. Warns by default.

How to fix it

Clippy does not fix this one automatically. Change the code by hand:

Flagged

// &&! looks like a different operator
if foo &&! bar {}

Write this instead

if foo && !bar {}

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::suspicious_unary_op_formatting)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
suspicious_unary_op_formatting = "allow"

One run

cargo clippy -- -A clippy::suspicious-unary-op-formatting

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Suspiciousgroup

warndefault level

nofixed by cargo clippy --fix

1.40.0added in Rust

Clippy's own documentation

What it does

Checks the formatting of a unary operator on the right hand side of a binary operator. It lints if there is no space between the binary and unary operators, but there is a space between the unary and its operand.

Why is this bad?

This is either a typo in the binary operator or confusing.

Example

// &&! looks like a different operator
if foo &&! bar {}

Use instead:

if foo && !bar {}

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Up next

Also worth your time

Did this answer your question?