Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::too_many_arguments: Checks for functions with too many parameters
What it meansChecks for functions with too many parameters. It is in the complexity group and warns by default.
Does it matter?
Functions with lots of parameters are considered bad style and reduce readability (“what does the 5th parameter mean?”). Consider grouping some parameters into a new type.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
fn foo(x: u32, y: u32, name: &str, c: Color, w: f32, h: f32, a: f32, b: f32) {
// ..
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::too_many_arguments)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
too_many_arguments = "allow"One run
cargo clippy -- -A clippy::too-many-argumentsThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
too-many-arguments-threshold: The maximum number of argument a function or method can have
Clippy's own documentation
What it does
Checks for functions with too many parameters.
Why is this bad?
Functions with lots of parameters are considered bad style and reduce readability (“what does the 5th parameter mean?”). Consider grouping some parameters into a new type.
Example
fn foo(x: u32, y: u32, name: &str, c: Color, w: f32, h: f32, a: f32, b: f32) {
// ..
}
Configuration
-
too-many-arguments-threshold: The maximum number of argument a function or method can have(default:
7)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- strlen_on_c_stringsChecks for usage of libc::strlen on a CString or CStr value, and suggest calling count_bytes() instead
- swap_with_temporaryswapping with a temporary value is inefficient
- temporary_assignmentassignment to temporary
- transmute_bytes_to_strtransmute from a `&[u8]` to a `&str`
- transmute_int_to_booltransmute from a `u8` to a `bool`
- transmute_int_to_non_zeroChecks for transmutes from T to NonZero<T>, and suggests the new_unchecked method instead
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::clone_on_copyusing `clone` on type `u64` which implements the `Copy` traitRead it next →Did this answer your question?