Clippy lints / Nursery
Clippy lint · Nursery · checked with Clippy 0.1.99
clippy::iter_on_empty_collections: Checks for calls to iter, iter_mut or into_iter on empty collections
What it meansChecks for calls to iter, iter_mut or into_iter on empty collections It is in the nursery group and off by default.
Does it matter?
It is simpler to use the empty function from the standard library:
New lints still being finished. Off by default and may have false positives.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
use std::{slice, option};
let a: slice::Iter<i32> = [].iter();
let f: option::IntoIter<i32> = None.into_iter();
Write this instead
use std::iter;
let a: iter::Empty<i32> = iter::empty();
let b: iter::Empty<i32> = iter::empty();
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
iter_on_empty_collections = "warn"In code
#![warn(clippy::iter_on_empty_collections)]One run
cargo clippy -- -W clippy::iter-on-empty-collectionsThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for calls to iter, iter_mut or into_iter on empty collections
Why is this bad?
It is simpler to use the empty function from the standard library:
Example
use std::{slice, option};
let a: slice::Iter<i32> = [].iter();
let f: option::IntoIter<i32> = None.into_iter();
Use instead:
use std::iter;
let a: iter::Empty<i32> = iter::empty();
let b: iter::Empty<i32> = iter::empty();
Known problems
The type of the resulting iterator might become incompatible with its usage
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- redundant_cloneChecks for a redundant clone() (and its relatives) which clones an owned value that is going to be dropped without further use
- fallible_impl_fromconsider implementing `TryFrom` instead
- future_not_sendfuture cannot be sent between threads safely
- imprecise_flopscube-root of a number can be computed more accurately
- iter_on_single_items`iter` call on a collection with only one item
- iter_with_drainChecks for usage of .drain(..) on Vec and VecDeque for iteration
- large_stack_framesChecks for functions that use a lot of stack space. This often happens when constructing a large type, such as an array with a lot of elements, or constructing many smaller-but-still-large structs, or copying around a lot of large types. This lint is a more general version of large_stack_arrays that is intended to look at functions as a whole instead of only individual array expressions inside of a function
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::redundant_cloneChecks for a redundant clone() (and its relatives) which clones an owned value that is going to be dropped without further useRead it next →Did this answer your question?