Clippy lints / Nursery
Clippy lint · Nursery · checked with Clippy 0.1.99
clippy::redundant_clone: Checks for a redundant clone() (and its relatives) which clones an owned value that is going to be dropped without further use
What it meansChecks for a redundant clone() (and its relatives) which clones an owned value that is going to be dropped without further use. It is in the nursery group and off by default.
Does it matter?
It is not always possible for the compiler to eliminate useless allocations and deallocations generated by redundant clone()s.
New lints still being finished. Off by default and may have false positives.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
{
let x = Foo::new();
call(x.clone());
call(x.clone()); // this can just pass `x`
}
["lorem", "ipsum"].join(" ").to_string();
Path::new("/a/b").join("c").to_path_buf();
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
redundant_clone = "warn"In code
#![warn(clippy::redundant_clone)]One run
cargo clippy -- -W clippy::redundant-cloneThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for a redundant clone() (and its relatives) which clones an owned
value that is going to be dropped without further use.
Why is this bad?
It is not always possible for the compiler to eliminate useless
allocations and deallocations generated by redundant clone()s.
Known problems
False-negatives: analysis performed by this lint is conservative and limited.
Example
{
let x = Foo::new();
call(x.clone());
call(x.clone()); // this can just pass `x`
}
["lorem", "ipsum"].join(" ").to_string();
Path::new("/a/b").join("c").to_path_buf();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- or_fun_callChecks for calls to .or(foo(..)), .unwrap_or(foo(..)), .or_insert(foo(..)) etc., and suggests to use .or_else(|| foo(..)), .unwrap_or_else(|| foo(..)), .unwrap_or_default() or .or_default() etc
- path_buf_push_overwritecalling `push` with '/' or '\' (file system root) will overwrite the previous path definition
- read_zero_byte_vecreading zero byte data to `Vec`
- redundant_pub_cratepub(crate) function inside private module
- search_is_somecalled `is_some()` after searching an `Iterator` with `find`
- set_contains_or_insertusage of `HashSet::insert` after `HashSet::contains`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::or_fun_callChecks for calls to .or(foo(..)), .unwrap_or(foo(..)), .or_insert(foo(..)) etc., and suggests to use .or_else(|| foo(..)), .unwrap_or_else(|| foo(..)), .unwrap_or_default() or .or_default() etcRead it next →Did this answer your question?