Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::iter_skip_next: called `skip(..).next()` on an iterator
What it meansChecks for usage of .skip(x).next() on iterators. It is in the style group and warns by default.
What you see
warning: called `skip(..).next()` on an iterator --> main.rs:4:30 | 4 | let bad_vec = some_vec.iter().skip(3).next(); | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(3)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#iter_skip_next = note: `#[warn(clippy::iter_skip_next)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
.nth(x) is cleaner
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let some_vec = vec![0, 1, 2, 3];
let bad_vec = some_vec.iter().skip(3).next();
let bad_slice = &some_vec[..].iter().skip(3).next();
Write this instead
let some_vec = vec![0, 1, 2, 3];
let bad_vec = some_vec.iter().nth(3);
let bad_slice = &some_vec[..].iter().nth(3);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::iter_skip_next)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
iter_skip_next = "allow"One run
cargo clippy -- -A clippy::iter-skip-nextThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of .skip(x).next() on iterators.
Why is this bad?
.nth(x) is cleaner
Example
let some_vec = vec![0, 1, 2, 3];
let bad_vec = some_vec.iter().skip(3).next();
let bad_slice = &some_vec[..].iter().skip(3).next();
The correct use would be:
let some_vec = vec![0, 1, 2, 3];
let bad_vec = some_vec.iter().nth(3);
let bad_slice = &some_vec[..].iter().nth(3);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- iter_next_sliceChecks for usage of iter().next() or iter_mut().next() on a Slice or an Array
- iter_nthcalled `.iter().nth()` on a `Vec`
- iter_nth_zeroChecks for the use of iter.nth(0)
- just_underscores_and_digitsconsider choosing a more descriptive name
- legacy_numeric_constantsusage of a legacy numeric constant
- len_without_is_emptyChecks for items that implement .len() but not .is_empty()
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?