Clippy lints / Pedantic
Clippy lint · Pedantic · checked with Clippy 0.1.99
clippy::mut_mut: multiple successive mutable borrows
What it meansChecks for instances of mut mut references. It is in the pedantic group and off by default.
What you see
warning: multiple successive mutable borrows --> main.rs:3:9 | 3 | let x = &mut &mut 1; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#mut_mut = note: `-W clippy::mut-mut` implied by `-W clippy::pedantic` help: make only a single borrow | 3 - let x = &mut &mut 1; 3 + let x = &mut 1; |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
This is usually just a typo or a misunderstanding of how references work.
Stricter lints with some false positives. Off by default; opt in with clippy::pedantic.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
let x = &mut &mut 1;
let mut x = &mut 1;
let y = &mut x;
fn foo(x: &mut &mut u32) {}
Write this instead
let x = &mut 1;
let mut x = &mut 1;
let y = &mut *x; // reborrow
fn foo(x: &mut u32) {}
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
mut_mut = "warn"In code
#![warn(clippy::mut_mut)]One run
cargo clippy -- -W clippy::mut-mutThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for instances of mut mut references.
Why is this bad?
This is usually just a typo or a misunderstanding of how references work.
Example
let x = &mut &mut 1;
let mut x = &mut 1;
let y = &mut x;
fn foo(x: &mut &mut u32) {}
Use instead
let x = &mut 1;
let mut x = &mut 1;
let y = &mut *x; // reborrow
fn foo(x: &mut u32) {}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_linesChecks for functions with a large amount of lines
- missing_errors_docChecks the doc comments of publicly visible functions that return a Result type and warns if there is no # Errors section
- must_use_candidateChecks for public functions that have no #[must_use] attribute, but return something not already marked must-use, have no mutable arg and mutate no statics
- missing_fields_in_debugmanual `Debug` impl does not include all fields
- missing_panics_docChecks the doc comments of publicly visible functions that may panic and warns if there is no # Panics section
- naive_bytecountChecks for naive byte counts
- needless_bitwise_booluse of bitwise operator instead of lazy operator between booleans
- needless_continueThe lint checks for if-statements appearing in loops that contain a continue statement in either their main blocks or their else-blocks, when omitting the else-block possibly with some rearrangement of code can make the code easier to understand. The lint also checks if the last statement in the loop is a continue
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_linesChecks for functions with a large amount of linesRead it next →Did this answer your question?