Clippy lints / Pedantic
Clippy lint · Pedantic · checked with Clippy 0.1.99
clippy::nonminimal_bool: Checks for boolean expressions that can be written more concisely
What it meansChecks for boolean expressions that can be written more concisely. It is in the pedantic group and off by default.
Does it matter?
Readability of boolean expressions suffers from unnecessary duplication.
Stricter lints with some false positives. Off by default; opt in with clippy::pedantic.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
if a && true {}
if !(a == b) {}
Write this instead
if a {}
if a != b {}
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
nonminimal_bool = "warn"In code
#![warn(clippy::nonminimal_bool)]One run
cargo clippy -- -W clippy::nonminimal-boolThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for boolean expressions that can be written more concisely.
Why is this bad?
Readability of boolean expressions suffers from unnecessary duplication.
Known problems
Ignores short circuiting behavior of || and
&&. Ignores |, & and ^.
Creates a big toll on performance, only enable sporadically
Example
if a && true {}
if !(a == b) {}
Use instead:
if a {}
if a != b {}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_linesChecks for functions with a large amount of lines
- missing_errors_docChecks the doc comments of publicly visible functions that return a Result type and warns if there is no # Errors section
- must_use_candidateChecks for public functions that have no #[must_use] attribute, but return something not already marked must-use, have no mutable arg and mutate no statics
- no_effect_underscore_bindingbinding to `_` prefixed variable with no side-effect
- no_mangle_with_rust_abi`#[no_mangle]` set on a function with the default (`Rust`) ABI
- non_std_lazy_staticsLints when once_cell::sync::Lazy or lazy_static! are used to define a static variable, and suggests replacing such cases with std::sync::LazyLock instead. Note: This lint will not trigger in crate with no_std context, or with MSRV < 1.80.0
- option_as_ref_clonedcloning an `Option<_>` using `.as_ref().cloned()`
- option_optionuse of `Option<Option<T>>`
- overly_complex_bool_exprChecks for boolean expressions that contain terminals that can be eliminated
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_linesChecks for functions with a large amount of linesRead it next →Did this answer your question?