Clippy lints / Pedantic
Clippy lint · Pedantic · checked with Clippy 0.1.99
clippy::overly_complex_bool_expr: Checks for boolean expressions that contain terminals that can be eliminated
What it meansChecks for boolean expressions that contain terminals that can be eliminated. It is in the pedantic group and off by default.
Does it matter?
This is most likely a logic bug.
Stricter lints with some false positives. Off by default; opt in with clippy::pedantic.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
// The `b` is unnecessary, the expression is equivalent to `if a`.
if a && b || a { ... }
Write this instead
if a {}
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
overly_complex_bool_expr = "warn"In code
#![warn(clippy::overly_complex_bool_expr)]One run
cargo clippy -- -W clippy::overly-complex-bool-exprThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for boolean expressions that contain terminals that can be eliminated.
Why is this bad?
This is most likely a logic bug.
Known problems
Ignores short circuiting behavior. Creates a big toll on performance, only enable sporadically
Example
// The `b` is unnecessary, the expression is equivalent to `if a`.
if a && b || a { ... }
Use instead:
if a {}
Past names
- logic_bug
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_linesChecks for functions with a large amount of lines
- missing_errors_docChecks the doc comments of publicly visible functions that return a Result type and warns if there is no # Errors section
- must_use_candidateChecks for public functions that have no #[must_use] attribute, but return something not already marked must-use, have no mutable arg and mutate no statics
- nonminimal_boolChecks for boolean expressions that can be written more concisely
- option_as_ref_clonedcloning an `Option<_>` using `.as_ref().cloned()`
- option_optionuse of `Option<Option<T>>`
- ptr_as_ptr`as` casting between raw pointers without changing their constness
- ptr_cast_constness`as` casting between raw pointers while changing only its constness
- ptr_offset_by_literaluse of `offset` with a literal
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_linesChecks for functions with a large amount of linesRead it next →Did this answer your question?