Clippy lints / Correctness
Clippy lint · Correctness · checked with Clippy 0.1.99
clippy::nonsensical_open_options: Checks for duplicate open options as well as combinations that make no sense
What it meansChecks for duplicate open options as well as combinations that make no sense. It is in the correctness group and denied by default (the build fails).
Does it matter?
In the best case, the code will be harder to read than necessary. I don’t know the worst case.
Code that is almost certainly wrong. Denied by default: the build fails until you fix it or allow it.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
use std::fs::OpenOptions;
OpenOptions::new().read(true).truncate(true);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::nonsensical_open_options)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
nonsensical_open_options = "allow"One run
cargo clippy -- -A clippy::nonsensical-open-optionsThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for duplicate open options as well as combinations that make no sense.
Why is this bad?
In the best case, the code will be harder to read than necessary. I don’t know the worst case.
Example
use std::fs::OpenOptions;
OpenOptions::new().read(true).truncate(true);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- mut_from_refThis lint checks for functions that take immutable references and return mutable ones
- never_loopthis loop never actually loops
- non_octal_unix_permissionsChecks for non-octal values used to set Unix file permissions
- not_unsafe_ptr_arg_derefthis public function might dereference a raw pointer but is not marked `unsafe`
- option_env_unwrapthis will panic at run-time if the environment variable doesn't exist at compile-time
- out_of_bounds_indexingindex is out of bounds
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::mut_from_refThis lint checks for functions that take immutable references and return mutable onesRead it next →Did this answer your question?