Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::option_as_ref_deref: Checks for usage of _.as_ref().map(Deref::deref) or its aliases (such as String::as_str)
What it meansChecks for usage of _.as_ref().map(Deref::deref) or its aliases (such as String::as_str). It is in the complexity group and warns by default.
Does it matter?
Readability, this can be written more concisely as _.as_deref().
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
opt.as_ref().map(String::as_str)
Write this instead
opt.as_deref()
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::option_as_ref_deref)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
option_as_ref_deref = "allow"One run
cargo clippy -- -A clippy::option-as-ref-derefThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
What it does
Checks for usage of _.as_ref().map(Deref::deref) or its aliases (such as String::as_str).
Why is this bad?
Readability, this can be written more concisely as
_.as_deref().
Example
opt.as_ref().map(String::as_str)
Can be written as
opt.as_deref()
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- no_effectstatement with no effect
- nonnull_unchecked_on_box_ptruse of `NonNull::new_unchecked` with `Box::into_raw`
- only_used_in_recursionparameter is only used in recursion
- option_filter_map`filter` for `Some` followed by `unwrap`
- option_map_unit_fnChecks for usage of option.map(f) where f is a function or closure that returns the unit type ()
- or_then_unwrapChecks for .or(…).unwrap() calls to Options and Results
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?