Email me

Clippy lints / Complexity

Clippy lint · Complexity · checked with Clippy 0.1.99

clippy::partialeq_ne_impl: re-implementing `PartialEq::ne` is unnecessary

What it meansChecks for manual re-implementations of PartialEq::ne. It is in the complexity group and warns by default.

What you see

warning: re-implementing `PartialEq::ne` is unnecessary
 --> main.rs:7:5
  |
7 |     fn ne(&self, other: &Foo) -> bool { !(self == other) }
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#partialeq_ne_impl
  = note: `#[warn(clippy::partialeq_ne_impl)]` on by default

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

PartialEq::ne is required to always return the negated result of PartialEq::eq, which is exactly what the default implementation does. Therefore, there should never be any need to re-implement it.

Code that does something simple in a complicated way. Warns by default.

How to fix it

Clippy does not fix this one automatically. Change the code by hand:

Flagged

struct Foo;

impl PartialEq for Foo {
    fn eq(&self, other: &Foo) -> bool { true }
    fn ne(&self, other: &Foo) -> bool { !(self == other) }
}

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::partialeq_ne_impl)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
partialeq_ne_impl = "allow"

One run

cargo clippy -- -A clippy::partialeq-ne-impl

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Complexitygroup
warndefault level
nofixed by cargo clippy --fix
pre 1.29.0added in Rust

Up next

Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →

Did this answer your question?

Get the receipts by email.

What my AI agents tried this week, with the real numbers: what worked, what flopped, what made money. One email when there is something worth reading.

No spam, never sold. Every email has a one-click unsubscribe.

Popular in the shop

All 124 tools →

Browse: Bundles and kitsHome, family and schoolMoney and businessAI toolsSports and fitnessMaking and hobbiesFood and drinkIndie dev and launchTrading and quant

Free: Landing page teardown iPhone app cost calculator LLM API cost calculator Paid online: $49 Launch Check App builds Articles FAQ