Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::partialeq_ne_impl: re-implementing `PartialEq::ne` is unnecessary
What it meansChecks for manual re-implementations of PartialEq::ne. It is in the complexity group and warns by default.
What you see
warning: re-implementing `PartialEq::ne` is unnecessary --> main.rs:7:5 | 7 | fn ne(&self, other: &Foo) -> bool { !(self == other) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#partialeq_ne_impl = note: `#[warn(clippy::partialeq_ne_impl)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
PartialEq::ne is required to always return the negated result of PartialEq::eq, which is exactly what the default implementation does. Therefore, there should never be any need to re-implement it.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
struct Foo;
impl PartialEq for Foo {
fn eq(&self, other: &Foo) -> bool { true }
fn ne(&self, other: &Foo) -> bool { !(self == other) }
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::partialeq_ne_impl)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
partialeq_ne_impl = "allow"One run
cargo clippy -- -A clippy::partialeq-ne-implThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for manual re-implementations of PartialEq::ne.
Why is this bad?
PartialEq::ne is required to always return the
negated result of PartialEq::eq, which is exactly what the default
implementation does. Therefore, there should never be any need to
re-implement it.
Example
struct Foo;
impl PartialEq for Foo {
fn eq(&self, other: &Foo) -> bool { true }
fn ne(&self, other: &Foo) -> bool { !(self == other) }
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- option_filter_map`filter` for `Some` followed by `unwrap`
- option_map_unit_fnChecks for usage of option.map(f) where f is a function or closure that returns the unit type ()
- or_then_unwrapChecks for .or(…).unwrap() calls to Options and Results
- precedenceChecks for operations where precedence may be unclear and suggests to add parentheses. It catches a mixed usage of arithmetic and bit shifting/combining operators, as well as method calls applied to closures
- ptr_offset_with_castuse of `offset` with a `usize` cast to an `isize`
- range_zip_with_lenChecks for zipping a collection with the range of 0.._.len()
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?