Clippy lint · Nursery · checked with Clippy 0.1.99

clippy::path_buf_push_overwrite: calling `push` with '/' or '\' (file system root) will overwrite the previous path definition

What it meansChecks for push calls on PathBuf that can cause overwrites. It is in the nursery group and off by default.

What you see

warning: calling `push` with '/' or '\' (file system root) will overwrite the previous path definition
 --> main.rs:6:8
  |
6 | x.push("/bar");
  |        ^^^^^^ help: try: `"bar"`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#path_buf_push_overwrite
  = note: `-W clippy::path-buf-push-overwrite` implied by `-W clippy::nursery`

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

Calling push with a root path at the start can overwrite the previous defined path.

New lints still being finished. Off by default and may have false positives.

How to fix it

Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:

Flagged

use std::path::PathBuf;

let mut x = PathBuf::from("/foo");
x.push("/bar");
assert_eq!(x, PathBuf::from("/bar"));

Write this instead

use std::path::PathBuf;

let mut x = PathBuf::from("/foo");
x.push("bar");
assert_eq!(x, PathBuf::from("/foo/bar"));

Turn it off, or on

It is off by default. To use it, set it to warn or deny:

Whole crate (Cargo.toml)

[lints.clippy]
path_buf_push_overwrite = "warn"

In code

#![warn(clippy::path_buf_push_overwrite)]

One run

cargo clippy -- -W clippy::path-buf-push-overwrite

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Nurserygroup

allowdefault level

nofixed by cargo clippy --fix

1.36.0added in Rust

Clippy's own documentation

What it does

Checks for push calls on PathBuf that can cause overwrites.

Why is this bad?

Calling push with a root path at the start can overwrite the previous defined path.

Example

use std::path::PathBuf;

let mut x = PathBuf::from("/foo");
x.push("/bar");
assert_eq!(x, PathBuf::from("/bar"));

Could be written:

use std::path::PathBuf;

let mut x = PathBuf::from("/foo");
x.push("bar");
assert_eq!(x, PathBuf::from("/foo/bar"));

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Up next

Also worth your time

Did this answer your question?