Clippy lints / Restriction
Clippy lint · Restriction · checked with Clippy 0.1.99
clippy::str_to_string: `to_string()` called on a `&str`
What it meansThis lint checks for .to_string() method calls on values of type &str. It is in the restriction group and off by default.
What you see
warning: `to_string()` called on a `&str` --> main.rs:3:9 | 3 | let _ = "str".to_string(); | ^^^^^^^^^^^^^^^^^ help: try: `"str".to_owned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#str_to_string = note: requested on the command line with `-W clippy::str-to-string`
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
The to_string method is also used on other types to convert them to a string. When called on a &str it turns the &str into the owned variant String, which can be more specifically expressed with .to_owned().
Lints that forbid language features for specific codebases (no unwrap, no indexing...). Off by default; pick them one by one, never the whole group.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let _ = "str".to_string();
Write this instead
let _ = "str".to_owned();
Turn it off, or on
It is off by default. To use it, set it to warn or deny:
Whole crate (Cargo.toml)
[lints.clippy]
str_to_string = "warn"In code
#![warn(clippy::str_to_string)]One run
cargo clippy -- -W clippy::str-to-stringThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
This lint checks for .to_string() method calls on values of type &str.
Why restrict this?
The to_string method is also used on other types to convert them to a string.
When called on a &str it turns the &str into the owned variant String, which can be
more specifically expressed with .to_owned().
Example
let _ = "str".to_string();
Use instead:
let _ = "str".to_owned();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- unwrap_usedChecks for .unwrap() or .unwrap_err() calls on Results and .unwrap() call on Options
- module_name_repetitionsDetects public item names that are prefixed or suffixed by the containing public module’s name
- expect_usedChecks for .expect() or .expect_err() calls on Results and .expect() call on Options
- single_char_lifetime_namessingle-character lifetime names are likely uninformative
- std_instead_of_allocused import from `std` instead of `alloc`
- std_instead_of_coreused import from `std` instead of `core`
- string_addyou added something to a string. Consider using `String::push_str()` instead
- string_lit_chars_anyChecks for <string_lit>.chars().any(|i| i == c)
- string_sliceindexing into a string may panic if the index is within a UTF-8 character
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::unwrap_usedChecks for .unwrap() or .unwrap_err() calls on Results and .unwrap() call on OptionsRead it next →Did this answer your question?