Clippy lints / Suspicious
Clippy lint · Suspicious · checked with Clippy 0.1.99
clippy::suspicious_command_arg_space: single argument that looks like it should be multiple arguments
What it meansChecks for Command::arg() invocations that look like they should be multiple arguments instead, such as arg("-t ext2"). It is in the suspicious group and warns by default.
What you see
warning: single argument that looks like it should be multiple arguments --> main.rs:3:40 | 3 | std::process::Command::new("echo").arg("-n hello").spawn().unwrap(); | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#suspicious_command_arg_space = note: `#[warn(clippy::suspicious_command_arg_space)]` on by default help: consider splitting the argument | 3 - std::process::Command::new("echo").arg("-n hello").spawn().unwrap(); 3 + std::process::Command::new("echo").args(["-n", "hello"]).spawn().unwrap(); |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Command::arg() does not split arguments by space. An argument like arg("-t ext2") will be passed as a single argument to the command, which is likely not what was intended.
Code that is most likely wrong or useless. Warns by default.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
std::process::Command::new("echo").arg("-n hello").spawn().unwrap();
Write this instead
std::process::Command::new("echo").args(["-n", "hello"]).spawn().unwrap();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::suspicious_command_arg_space)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
suspicious_command_arg_space = "allow"One run
cargo clippy -- -A clippy::suspicious-command-arg-spaceThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for Command::arg() invocations that look like they
should be multiple arguments instead, such as arg("-t ext2").
Why is this bad?
Command::arg() does not split arguments by space. An argument like arg("-t ext2")
will be passed as a single argument to the command,
which is likely not what was intended.
Example
std::process::Command::new("echo").arg("-n hello").spawn().unwrap();
Use instead:
std::process::Command::new("echo").args(["-n", "hello"]).spawn().unwrap();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- size_of_refargument to `size_of_val()` is a reference to a reference
- suspicious_arithmetic_implLints for suspicious operations in impls of arithmetic operators, e.g. subtracting elements in an Add impl
- suspicious_assignment_formattingthis looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)`
- suspicious_doc_commentsthis is an outer doc comment and does not apply to the parent module or crate
- suspicious_else_formattingthis is an `else {..}` but the formatting might hide it
- suspicious_mapthis call to `map()` won't have an effect on the call to `count()`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::size_of_refargument to `size_of_val()` is a reference to a referenceRead it next →Did this answer your question?