Clippy lint · Suspicious · checked with Clippy 0.1.99

clippy::suspicious_arithmetic_impl: Lints for suspicious operations in impls of arithmetic operators, e.g. subtracting elements in an Add impl

What it meansLints for suspicious operations in impls of arithmetic operators, e.g. subtracting elements in an Add impl. It is in the suspicious group and warns by default.

Does it matter?

This is probably a typo or copy-and-paste error and not intended.

Code that is most likely wrong or useless. Warns by default.

How to fix it

Clippy does not fix this one automatically. Change the code by hand:

Flagged

impl Add for Foo {
    type Output = Foo;

    fn add(self, other: Foo) -> Foo {
        Foo(self.0 - other.0)
    }
}

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::suspicious_arithmetic_impl)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
suspicious_arithmetic_impl = "allow"

One run

cargo clippy -- -A clippy::suspicious-arithmetic-impl

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Suspiciousgroup

warndefault level

nofixed by cargo clippy --fix

pre 1.29.0added in Rust

Clippy's own documentation

What it does

Lints for suspicious operations in impls of arithmetic operators, e.g. subtracting elements in an Add impl.

Why is this bad?

This is probably a typo or copy-and-paste error and not intended.

Example

impl Add for Foo {
    type Output = Foo;

    fn add(self, other: Foo) -> Foo {
        Foo(self.0 - other.0)
    }
}

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Up next

Also worth your time

Did this answer your question?