Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::unneeded_wildcard_pattern: this pattern is unneeded as the `..` pattern can match that element
What it meansChecks for tuple and struct patterns with a wildcard pattern (_) is next to a rest pattern (..). NOTE: While _, .. means there is at least one element left, .. means there are 0 or more elements left. This can make a difference when refactoring, but shouldn’t result in errors in the refactored code, since the wildcard pattern isn’t used anyway. It is in the complexity group and warns by default.
What you see
warning: this pattern is unneeded as the `..` pattern can match that element --> main.rs:4:22 | 4 | TupleStruct(0, .., _) => (), | ^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#unneeded_wildcard_pattern = note: `#[warn(clippy::unneeded_wildcard_pattern)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
The wildcard pattern is unneeded as the rest pattern can match that element as well.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
match t {
TupleStruct(0, .., _) => (),
_ => (),
}
Write this instead
match t {
TupleStruct(0, ..) => (),
_ => (),
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::unneeded_wildcard_pattern)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
unneeded_wildcard_pattern = "allow"One run
cargo clippy -- -A clippy::unneeded-wildcard-patternThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for tuple and struct patterns with a wildcard
pattern (_) is next to a rest pattern (..).
NOTE: While _, .. means there is at least one element left, ..
means there are 0 or more elements left. This can make a difference
when refactoring, but shouldn’t result in errors in the refactored code,
since the wildcard pattern isn’t used anyway.
Why is this bad?
The wildcard pattern is unneeded as the rest pattern can match that element as well.
Example
match t {
TupleStruct(0, .., _) => (),
_ => (),
}
Use instead:
match t {
TupleStruct(0, ..) => (),
_ => (),
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- unnecessary_sort_byChecks for usage of Vec::sort_by passing in a closure which compares the two arguments, either directly or indirectly
- unnecessary_unwrapChecks for calls of unwrap[_err]() that cannot fail
- unnecessary_unwrap_uncheckedusage of `unwrap_unchecked` when an `_unchecked` variant of the function exists
- unused_format_specsformat specifiers have no effect on `format_args!()`
- useless_asrefChecks for usage of .as_ref() or .as_mut() where the types before and after the call are the same
- useless_concatunneeded use of `concat!` macro
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?