Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::useless_nonzero_new_unchecked: `NonZeroUsize::new()` and `Option::unwrap()` can be safely used in a `const` context
What it meansChecks for NonZero*::new_unchecked() being used in a const context. It is in the complexity group and warns by default.
What you see
warning: `NonZeroUsize::new()` and `Option::unwrap()` can be safely used in a `const` context --> main.rs:4:31 | 4 | const PLAYERS: NonZeroUsize = unsafe { NonZeroUsize::new_unchecked(3) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use instead: `NonZeroUsize::new(3).unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#useless_nonzero_new_unchecked = note: `#[warn(clippy::useless_nonzero_new_unchecked)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Using NonZero*::new_unchecked() is an unsafe function and requires an unsafe context. When used in a context evaluated at compilation time, NonZero*::new().unwrap() will provide the same result with identical runtime performances while not requiring unsafe.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
use std::num::NonZeroUsize;
const PLAYERS: NonZeroUsize = unsafe { NonZeroUsize::new_unchecked(3) };
Write this instead
use std::num::NonZeroUsize;
const PLAYERS: NonZeroUsize = NonZeroUsize::new(3).unwrap();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::useless_nonzero_new_unchecked)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
useless_nonzero_new_unchecked = "allow"One run
cargo clippy -- -A clippy::useless-nonzero-new-uncheckedThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for NonZero*::new_unchecked() being used in a const context.
Why is this bad?
Using NonZero*::new_unchecked() is an unsafe function and requires an unsafe context. When used in a
context evaluated at compilation time, NonZero*::new().unwrap() will provide the same result with identical
runtime performances while not requiring unsafe.
Example
use std::num::NonZeroUsize;
const PLAYERS: NonZeroUsize = unsafe { NonZeroUsize::new_unchecked(3) };
Use instead:
use std::num::NonZeroUsize;
const PLAYERS: NonZeroUsize = NonZeroUsize::new(3).unwrap();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- useless_concatunneeded use of `concat!` macro
- useless_conversionuseless conversion to the same type: `std::string::String`
- useless_formatuseless use of `format!`
- useless_transmuteChecks for transmutes to the original type of the object and transmutes that could be a cast
- vec_box`Vec<T>` is already on the heap, the boxing is unnecessary
- while_let_loopthis loop could be written as a `while let` loop
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?