Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::duration_subsec: Checks for calculation of subsecond microseconds or milliseconds from other Duration methods
What it meansChecks for calculation of subsecond microseconds or milliseconds from other Duration methods. It is in the complexity group and warns by default.
Does it matter?
It’s more concise to call Duration::subsec_micros() or Duration::subsec_millis() than to calculate them.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let micros = duration.subsec_nanos() / 1_000;
let millis = duration.subsec_nanos() / 1_000_000;
Write this instead
let micros = duration.subsec_micros();
let millis = duration.subsec_millis();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::duration_subsec)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
duration_subsec = "allow"One run
cargo clippy -- -A clippy::duration-subsecThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for calculation of subsecond microseconds or milliseconds
from other Duration methods.
Why is this bad?
It’s more concise to call Duration::subsec_micros() or
Duration::subsec_millis() than to calculate them.
Example
let micros = duration.subsec_nanos() / 1_000;
let millis = duration.subsec_nanos() / 1_000_000;
Use instead:
let micros = duration.subsec_micros();
let millis = duration.subsec_millis();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- diverging_sub_expressionChecks for diverging calls that are not match arms or statements
- double_comparisonsChecks for double comparisons that could be simplified to a single expression
- double_parensunnecessary parentheses
- excessive_nestingChecks for blocks which are nested beyond a certain threshold. Note: Even though this lint is warn-by-default, it will only trigger if a maximum nesting level is defined in the clippy.toml file
- explicit_auto_derefderef which would be done by auto-deref
- explicit_counter_loopChecks for loops over slices with an explicit counter and suggests the use of .enumerate()
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?