Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::excessive_nesting: Checks for blocks which are nested beyond a certain threshold. Note: Even though this lint is warn-by-default, it will only trigger if a maximum nesting level is defined in the clippy.toml file
What it meansChecks for blocks which are nested beyond a certain threshold. Note: Even though this lint is warn-by-default, it will only trigger if a maximum nesting level is defined in the clippy.toml file. It is in the complexity group and warns by default.
Does it matter?
It can severely hinder readability.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
// lib.rs
pub mod a {
pub struct X;
impl X {
pub fn run(&self) {
if true {
// etc...
}
}
}
}
Write this instead
// a.rs
fn private_run(x: &X) {
if true {
// etc...
}
}
pub struct X;
impl X {
pub fn run(&self) {
private_run(self);
}
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::excessive_nesting)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
excessive_nesting = "allow"One run
cargo clippy -- -A clippy::excessive-nestingThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
excessive-nesting-threshold: The maximum amount of nesting a block can reside in
Clippy's own documentation
What it does
Checks for blocks which are nested beyond a certain threshold.
Note: Even though this lint is warn-by-default, it will only trigger if a maximum nesting level is defined in the clippy.toml file.
Why is this bad?
It can severely hinder readability.
Example
An example clippy.toml configuration:
excessive-nesting-threshold = 3
// lib.rs
pub mod a {
pub struct X;
impl X {
pub fn run(&self) {
if true {
// etc...
}
}
}
}
Use instead:
// a.rs
fn private_run(x: &X) {
if true {
// etc...
}
}
pub struct X;
impl X {
pub fn run(&self) {
private_run(self);
}
}
// lib.rs
pub mod a;
Configuration
-
excessive-nesting-threshold: The maximum amount of nesting a block can reside in(default:
0)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- double_comparisonsChecks for double comparisons that could be simplified to a single expression
- double_parensunnecessary parentheses
- duration_subsecChecks for calculation of subsecond microseconds or milliseconds from other Duration methods
- explicit_auto_derefderef which would be done by auto-deref
- explicit_counter_loopChecks for loops over slices with an explicit counter and suggests the use of .enumerate()
- explicit_writeChecks for usage of write!() / writeln()! which can be replaced with (e)print!() / (e)println!()
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?