Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::field_reassign_with_default: Checks for immediate reassignment of fields initialized with Default::default()
What it meansChecks for immediate reassignment of fields initialized with Default::default(). It is in the style group and warns by default.
Does it matter?
It’s more idiomatic to use the functional update syntax.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
let mut a: A = Default::default();
a.i = 42;
Write this instead
let a = A {
i: 42,
.. Default::default()
};
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::field_reassign_with_default)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
field_reassign_with_default = "allow"One run
cargo clippy -- -A clippy::field-reassign-with-defaultThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for immediate reassignment of fields initialized with Default::default().
Why is this bad?
It’s more idiomatic to use the functional update syntax.
Known problems
Assignments to patterns that are of tuple type are not linted.
Example
let mut a: A = Default::default();
a.i = 42;
Use instead:
let a = A {
i: 42,
.. Default::default()
};
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- enum_variant_namesvariant name ends with the enum's name
- err_expectcalled `.err().expect()` on a `Result` value
- excessive_precisionfloat has excessive precision
- filter_map_bool_thenChecks for usage of bool::then in Iterator::filter_map
- fn_to_numeric_castcasting function pointer `fun` to `i64`
- fn_to_numeric_cast_with_truncationcasting function pointer `fn1` to `i32`, which truncates the value
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?