Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::from_str_radix_10: Checks for function invocations of the form primitive::from_str_radix(s, 10)
What it meansChecks for function invocations of the form primitive::from_str_radix(s, 10) It is in the style group and warns by default.
Does it matter?
This specific common use case can be rewritten as s.parse::<primitive>() (and in most cases, the turbofish can be removed), which reduces code length and complexity.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
let input: &str = get_input();
let num = u16::from_str_radix(input, 10)?;
Write this instead
let input: &str = get_input();
let num: u16 = input.parse()?;
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::from_str_radix_10)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
from_str_radix_10 = "allow"One run
cargo clippy -- -A clippy::from-str-radix-10The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for function invocations of the form primitive::from_str_radix(s, 10)
Why is this bad?
This specific common use case can be rewritten as s.parse::<primitive>()
(and in most cases, the turbofish can be removed), which reduces code length
and complexity.
Known problems
This lint may suggest using (&<expression>).parse() instead of <expression>.parse()
directly in some cases, which is correct but adds unnecessary complexity to the code.
Example
let input: &str = get_input();
let num = u16::from_str_radix(input, 10)?;
Use instead:
let input: &str = get_input();
let num: u16 = input.parse()?;
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- fn_to_numeric_cast_with_truncationcasting function pointer `fn1` to `i32`, which truncates the value
- for_kv_mapChecks for iterating a map (HashMap or BTreeMap) and ignoring either the keys or values
- from_over_intoan implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
- get_firstaccessing first element with `x.get(0)`
- if_same_then_elseChecks for if/else with the same body as the then part and the else part
- implicit_saturating_addmanual saturating add detected
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?