Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::if_same_then_else: Checks for if/else with the same body as the then part and the else part
What it meansChecks for if/else with the same body as the then part and the else part. It is in the style group and warns by default.
Does it matter?
This is probably a copy & paste error.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
let foo = if … {
42
} else {
42
};
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::if_same_then_else)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
if_same_then_else = "allow"One run
cargo clippy -- -A clippy::if-same-then-elseThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for if/else with the same body as the then part
and the else part.
Why is this bad?
This is probably a copy & paste error.
Example
let foo = if … {
42
} else {
42
};
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- from_over_intoan implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
- from_str_radix_10Checks for function invocations of the form primitive::from_str_radix(s, 10)
- get_firstaccessing first element with `x.get(0)`
- implicit_saturating_addmanual saturating add detected
- implicit_saturating_subChecks for implicit saturating subtraction
- inconsistent_digit_groupingdigits grouped inconsistently by underscores
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?