Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::manual_filter: manual implementation of `Option::filter`
What it meansChecks for usage of match which could be implemented using filter It is in the complexity group and warns by default.
What you see
warning: manual implementation of `Option::filter` --> main.rs:3:1 | 3 | / match Some(0) { 4 | | Some(x) => if x % 2 == 0 { 5 | | Some(x) 6 | | } else { ... | 9 | | None => None, 10 | | }; | |_^ help: try: `Some(0).filter(|&x| x % 2 == 0)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_filter = note: `#[warn(clippy::manual_filter)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Using the filter method is clearer and more concise.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
match Some(0) {
Some(x) => if x % 2 == 0 {
Some(x)
} else {
None
},
None => None,
};
Write this instead
Some(0).filter(|&x| x % 2 == 0);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_filter)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_filter = "allow"One run
cargo clippy -- -A clippy::manual-filterThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of match which could be implemented using filter
Why is this bad?
Using the filter method is clearer and more concise.
Example
match Some(0) {
Some(x) => if x % 2 == 0 {
Some(x)
} else {
None
},
None => None,
};
Use instead:
Some(0).filter(|&x| x % 2 == 0);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- manual_checked_opsDetects manual zero checks before dividing integers, such as if x != 0 { y / x }
- manual_clampIdentifies good opportunities for a clamp function from std or core, and suggests using it
- manual_div_ceilChecks for an expression like (x + (y - 1)) / y which is a common manual reimplementation of x.div_ceil(y)
- manual_filter_map`filter(..).map(..)` can be simplified as `filter_map(..)`
- manual_findmanual implementation of `Iterator::find`
- manual_find_map`find(..).map(..)` can be simplified as `find_map(..)`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?