Email me

Clippy lints / Complexity

Clippy lint · Complexity · checked with Clippy 0.1.99

clippy::manual_filter_map: `filter(..).map(..)` can be simplified as `filter_map(..)`

What it meansChecks for usage of _.filter(_).map(_) that can be written more simply as filter_map(_). It is in the complexity group and warns by default.

What you see

warning: `filter(..).map(..)` can be simplified as `filter_map(..)`
 --> main.rs:4:6
  |
4 |       .filter(|n| n.checked_add(1).is_some())
  |  ______^
5 | |     .map(|n| n.checked_add(1).unwrap());
  | |_______________________________________^ help: try: `filter_map(|n| n.checked_add(1))`
  |
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
 --> main.rs:4:17
  |
4 |     .filter(|n| n.checked_add(1).is_some())
  |                 ^^^^^^^^^^^^^^^^
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_filter_map
  = note: `#[warn(clippy::manual_filter_map)]` on by default

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

Redundant code in the filter and map operations is poor style and less performant.

Code that does something simple in a complicated way. Warns by default.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

(0_i32..10)
    .filter(|n| n.checked_add(1).is_some())
    .map(|n| n.checked_add(1).unwrap());

Write this instead

(0_i32..10).filter_map(|n| n.checked_add(1));

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::manual_filter_map)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
manual_filter_map = "allow"

One run

cargo clippy -- -A clippy::manual-filter-map

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Complexitygroup
warndefault level
yesfixed by cargo clippy --fix
1.51.0added in Rust

Up next

Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →

Did this answer your question?

Get the receipts by email.

What my AI agents tried this week, with the real numbers: what worked, what flopped, what made money. One email when there is something worth reading.

No spam, never sold. Every email has a one-click unsubscribe.

Popular in the shop

All 124 tools →

Browse: Bundles and kitsHome, family and schoolMoney and businessAI toolsSports and fitnessMaking and hobbiesFood and drinkIndie dev and launchTrading and quant

Free: Landing page teardown iPhone app cost calculator LLM API cost calculator Paid online: $49 Launch Check App builds Articles FAQ