Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::manual_is_finite: Checks for manual is_finite reimplementations (i.e., x != <float>::INFINITY && x != <float>::NEG_INFINITY)
What it meansChecks for manual is_finite reimplementations (i.e., x != <float>::INFINITY && x != <float>::NEG_INFINITY). It is in the style group and warns by default.
Does it matter?
The method is_finite is shorter and more readable.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
if x != f32::INFINITY && x != f32::NEG_INFINITY {}
if x.abs() < f32::INFINITY {}
Write this instead
if x.is_finite() {}
if x.is_finite() {}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_is_finite)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_is_finite = "allow"One run
cargo clippy -- -A clippy::manual-is-finiteThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for manual is_finite reimplementations
(i.e., x != <float>::INFINITY && x != <float>::NEG_INFINITY).
Why is this bad?
The method is_finite is shorter and more readable.
Example
if x != f32::INFINITY && x != f32::NEG_INFINITY {}
if x.abs() < f32::INFINITY {}
Use instead:
if x.is_finite() {}
if x.is_finite() {}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- manual_bitsusage of `size_of::<T>()` to obtain the size of `T` in bits
- manual_dangling_ptrmanual creation of a dangling pointer
- manual_is_ascii_checkmanual check for common ascii range
- manual_is_infiniteChecks for manual is_infinite reimplementations (i.e., x == <float>::INFINITY || x == <float>::NEG_INFINITY)
- manual_mapmanual implementation of `Option::map`
- manual_next_backChecks for .rev().next() on a DoubleEndedIterator
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?