Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::manual_map: manual implementation of `Option::map`
What it meansChecks for usage of match which could be implemented using map It is in the style group and warns by default.
What you see
warning: manual implementation of `Option::map` --> main.rs:3:1 | 3 | / match Some(0) { 4 | | Some(x) => Some(x + 1), 5 | | None => None, 6 | | }; | |_^ help: try: `Some(0).map(|x| x + 1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Using the map method is clearer and more concise.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
match Some(0) {
Some(x) => Some(x + 1),
None => None,
};
Write this instead
Some(0).map(|x| x + 1);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_map)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_map = "allow"One run
cargo clippy -- -A clippy::manual-mapThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of match which could be implemented using map
Why is this bad?
Using the map method is clearer and more concise.
Example
match Some(0) {
Some(x) => Some(x + 1),
None => None,
};
Use instead:
Some(0).map(|x| x + 1);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- manual_is_ascii_checkmanual check for common ascii range
- manual_is_finiteChecks for manual is_finite reimplementations (i.e., x != <float>::INFINITY && x != <float>::NEG_INFINITY)
- manual_is_infiniteChecks for manual is_infinite reimplementations (i.e., x == <float>::INFINITY || x == <float>::NEG_INFINITY)
- manual_next_backChecks for .rev().next() on a DoubleEndedIterator
- manual_non_exhaustiveChecks for manual implementations of the non-exhaustive pattern
- manual_ok_orthis pattern reimplements `Option::ok_or`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?