Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::manual_is_multiple_of: Checks for manual implementation of .is_multiple_of() on unsigned integer types
What it meansChecks for manual implementation of .is_multiple_of() on unsigned integer types. It is in the complexity group and warns by default.
Does it matter?
a.is_multiple_of(b) is a clearer way to check for divisibility of a by b. This expression can never panic.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
if a % b == 0 {
println!("{a} is divisible by {b}");
}
Write this instead
if a.is_multiple_of(b) {
println!("{a} is divisible by {b}");
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_is_multiple_of)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_is_multiple_of = "allow"One run
cargo clippy -- -A clippy::manual-is-multiple-ofThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for manual implementation of .is_multiple_of() on
unsigned integer types.
Why is this bad?
a.is_multiple_of(b) is a clearer way to check for divisibility
of a by b. This expression can never panic.
Example
if a % b == 0 {
println!("{a} is divisible by {b}");
}
Use instead:
if a.is_multiple_of(b) {
println!("{a} is divisible by {b}");
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- manual_flattenunnecessary `if let` since only the `Some` variant of the iterator element is used
- manual_hash_onemanual implementation of `BuildHasher::hash_one`
- manual_inspectusing `map` over `inspect`
- manual_isolate_lowest_onemanual implementation of `isolate_lowest_one`
- manual_main_separator_strtaking a reference on `std::path::MAIN_SEPARATOR` conversion to `String`
- manual_noop_wakerChecks for manual implementations of std::task::Wake that are empty
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?