Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::manual_isolate_lowest_one: manual implementation of `isolate_lowest_one`
What it meansChecks for manual implementations of isolating the lowest set bit. It is in the complexity group and warns by default.
What you see
warning: manual implementation of `isolate_lowest_one` --> main.rs:4:11 | 4 | let lsb = x & x.wrapping_neg(); | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.isolate_lowest_one()`: `x.isolate_lowest_one()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_isolate_lowest_one = note: `#[warn(clippy::manual_isolate_lowest_one)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
The manual bit-twiddling forms are harder to read than the standard library method. Using -x can also overflow for signed minimum values.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let x: u32 = 5;
let lsb = x & x.wrapping_neg();
Write this instead
let x: u32 = 5;
let lsb = x.isolate_lowest_one();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_isolate_lowest_one)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_isolate_lowest_one = "allow"One run
cargo clippy -- -A clippy::manual-isolate-lowest-oneThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
What it does
Checks for manual implementations of isolating the lowest set bit.
Why is this bad?
The manual bit-twiddling forms are harder to read than the standard library method.
Using -x can also overflow for signed minimum values.
Example
let x: u32 = 5;
let lsb = x & x.wrapping_neg();
Use instead:
let x: u32 = 5;
let lsb = x.isolate_lowest_one();
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- manual_hash_onemanual implementation of `BuildHasher::hash_one`
- manual_inspectusing `map` over `inspect`
- manual_is_multiple_ofChecks for manual implementation of .is_multiple_of() on unsigned integer types
- manual_main_separator_strtaking a reference on `std::path::MAIN_SEPARATOR` conversion to `String`
- manual_noop_wakerChecks for manual implementations of std::task::Wake that are empty
- manual_ok_errChecks for manual implementation of .ok() or .err() on Result values
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?