Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::manual_non_exhaustive: Checks for manual implementations of the non-exhaustive pattern
What it meansChecks for manual implementations of the non-exhaustive pattern. It is in the style group and warns by default.
Does it matter?
Using the #[non_exhaustive] attribute expresses better the intent and allows possible optimizations when applied to enums.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
struct S {
pub a: i32,
pub b: i32,
_c: (),
}
enum E {
A,
B,
#[doc(hidden)]
_C,
}
struct T(pub i32, pub i32, ());
Write this instead
#[non_exhaustive]
struct S {
pub a: i32,
pub b: i32,
}
#[non_exhaustive]
enum E {
A,
B,
}
#[non_exhaustive]
struct T(pub i32, pub i32);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_non_exhaustive)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_non_exhaustive = "allow"One run
cargo clippy -- -A clippy::manual-non-exhaustiveThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
What it does
Checks for manual implementations of the non-exhaustive pattern.
Why is this bad?
Using the #[non_exhaustive] attribute expresses better the intent and allows possible optimizations when applied to enums.
Example
struct S {
pub a: i32,
pub b: i32,
_c: (),
}
enum E {
A,
B,
#[doc(hidden)]
_C,
}
struct T(pub i32, pub i32, ());
Use instead:
#[non_exhaustive]
struct S {
pub a: i32,
pub b: i32,
}
#[non_exhaustive]
enum E {
A,
B,
}
#[non_exhaustive]
struct T(pub i32, pub i32);
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- manual_is_infiniteChecks for manual is_infinite reimplementations (i.e., x == <float>::INFINITY || x == <float>::NEG_INFINITY)
- manual_mapmanual implementation of `Option::map`
- manual_next_backChecks for .rev().next() on a DoubleEndedIterator
- manual_ok_orthis pattern reimplements `Option::ok_or`
- manual_pattern_char_comparisonthis manual char comparison can be written more succinctly
- manual_range_containsmanual `Range::contains` implementation
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?