Clippy lint · Complexity · checked with Clippy 0.1.99

clippy::manual_pop_if: Checks for code to be replaced by pop_if methods

What it meansChecks for code to be replaced by pop_if methods. It is in the complexity group and warns by default.

Does it matter?

Using pop_if is more concise and idiomatic.

Code that does something simple in a complicated way. Warns by default.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

if vec.last().is_some_and(|x| *x > 5) {
    vec.pop().unwrap();
}
if deque.back().is_some_and(|x| *x > 5) {
    deque.pop_back().unwrap();
}
if deque.front().is_some_and(|x| *x > 5) {
    deque.pop_front().unwrap();
}

Write this instead

vec.pop_if(|x| *x > 5);
deque.pop_back_if(|x| *x > 5);
deque.pop_front_if(|x| *x > 5);

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::manual_pop_if)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
manual_pop_if = "allow"

One run

cargo clippy -- -A clippy::manual-pop-if

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Complexitygroup

warndefault level

yesfixed by cargo clippy --fix

1.96.0added in Rust

Clippy's own documentation

What it does

Checks for code to be replaced by pop_if methods.

Why is this bad?

Using pop_if is more concise and idiomatic.

Known issues

When the popped value is assigned or used in an expression, or when the if condition is part of an else if branch, the lint will trigger but will not provide an automatic suggestion.

Examples

if vec.last().is_some_and(|x| *x > 5) {
    vec.pop().unwrap();
}
if deque.back().is_some_and(|x| *x > 5) {
    deque.pop_back().unwrap();
}
if deque.front().is_some_and(|x| *x > 5) {
    deque.pop_front().unwrap();
}

Use instead:

vec.pop_if(|x| *x > 5);
deque.pop_back_if(|x| *x > 5);
deque.pop_front_if(|x| *x > 5);

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Up next

Also worth your time

Did this answer your question?