Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::manual_rem_euclid: manual `rem_euclid` implementation
What it meansChecks for an expression like ((x % 4) + 4) % 4 which is a common manual reimplementation of x.rem_euclid(4). It is in the complexity group and warns by default.
What you see
warning: manual `rem_euclid` implementation --> main.rs:4:11 | 4 | let rem = ((x % 4) + 4) % 4; | ^^^^^^^^^^^^^^^^^ help: consider using: `x.rem_euclid(4)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_rem_euclid = note: `#[warn(clippy::manual_rem_euclid)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
It’s simpler and more readable.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let x: i32 = 24;
let rem = ((x % 4) + 4) % 4;
Write this instead
let x: i32 = 24;
let rem = x.rem_euclid(4);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_rem_euclid)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_rem_euclid = "allow"One run
cargo clippy -- -A clippy::manual-rem-euclidThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
What it does
Checks for an expression like ((x % 4) + 4) % 4 which is a common manual reimplementation
of x.rem_euclid(4).
Why is this bad?
It’s simpler and more readable.
Example
let x: i32 = 24;
let rem = ((x % 4) + 4) % 4;
Use instead:
let x: i32 = 24;
let rem = x.rem_euclid(4);
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- manual_option_zipmanual implementation of `Option::zip`
- manual_pop_ifChecks for code to be replaced by pop_if methods
- manual_range_patternsthis OR pattern can be rewritten using a range
- manual_slice_size_calculationWhen a is &[T], detect a.len() * size_of::<T>() and suggest size_of_val(a) instead
- manual_split_onceChecks for usage of str::splitn(2, _)
- manual_stripstripping a prefix manually
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?