clippy::manual_take: manual implementation of `mem::take`

What you see

warning: manual implementation of `mem::take`
 --> main.rs:4:9
  |
4 |   let _ = if x {
  |  _________^
5 | |     x = false;
6 | |     true
7 | | } else {
8 | |     false
9 | | };
  | |_^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_take
  = note: `#[warn(clippy::manual_take)]` on by default
help: use
  |
4 - let _ = if x {
5 -     x = false;
6 -     true
7 - } else {
8 -     false
9 - };
4 + let _ = std::mem::take(&mut x);
  |

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

Because the function call is shorter and easier to read.

Code that does something simple in a complicated way. Warns by default.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

let mut x = true;
let _ = if x {
    x = false;
    true
} else {
    false
};

Write this instead

let mut x = true;
let _ = std::mem::take(&mut x);

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

#[allow(clippy::manual_take)]
fn my_function() { /* ... */ }

[lints.clippy]
manual_take = "allow"

cargo clippy -- -A clippy::manual-take

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Settings in clippy.toml

• msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml