Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::manual_unwrap_or: this pattern reimplements `Option::unwrap_or`
What it meansFinds patterns that reimplement Option::unwrap_or or Result::unwrap_or. It is in the complexity group and warns by default.
What you see
warning: this pattern reimplements `Option::unwrap_or` --> main.rs:4:1 | 4 | / match foo { 5 | | Some(v) => v, 6 | | None => 1, 7 | | }; | |_^ help: replace with: `foo.unwrap_or(1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#manual_unwrap_or = note: `#[warn(clippy::manual_unwrap_or)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Concise code helps focusing on behavior instead of boilerplate.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let foo: Option<i32> = None;
match foo {
Some(v) => v,
None => 1,
};
Write this instead
let foo: Option<i32> = None;
foo.unwrap_or(1);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::manual_unwrap_or)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
manual_unwrap_or = "allow"One run
cargo clippy -- -A clippy::manual-unwrap-orThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Finds patterns that reimplement Option::unwrap_or or Result::unwrap_or.
Why is this bad?
Concise code helps focusing on behavior instead of boilerplate.
Example
let foo: Option<i32> = None;
match foo {
Some(v) => v,
None => 1,
};
Use instead:
let foo: Option<i32> = None;
foo.unwrap_or(1);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- manual_stripstripping a prefix manually
- manual_swapthis looks like you are swapping `b` and `a` manually
- manual_takemanual implementation of `mem::take`
- map_all_any_identityChecks for usage of .map(…), followed by .all(identity) or .any(identity)
- map_flattencalled `map(..).flatten()` on `Iterator`
- map_identityunnecessary map of the identity function
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?