Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::map_or_identity: expression can be simplified using `Option::unwrap_or()`
What it meansChecks the usage of .map_or(...) with an identity function for Option and Result types. It is in the complexity group and warns by default.
What you see
warning: expression can be simplified using `Option::unwrap_or()` --> main.rs:4:1 | 4 | opt.map_or(42, |v| v); | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#map_or_identity = note: `#[warn(clippy::map_or_identity)]` on by default help: consider using `unwrap_or` | 4 - opt.map_or(42, |v| v); 4 + opt.unwrap_or(42); |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
This can be written more concisely by using unwrap_or().
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let opt = Some(1);
opt.map_or(42, |v| v);
Write this instead
let opt = Some(1);
opt.unwrap_or(42);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::map_or_identity)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
map_or_identity = "allow"One run
cargo clippy -- -A clippy::map-or-identityThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks the usage of .map_or(...) with an identity function for Option and Result types.
Why is this bad?
This can be written more concisely by using unwrap_or().
Example
let opt = Some(1);
opt.map_or(42, |v| v);
Use instead:
let opt = Some(1);
opt.unwrap_or(42);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- map_all_any_identityChecks for usage of .map(…), followed by .all(identity) or .any(identity)
- map_flattencalled `map(..).flatten()` on `Iterator`
- map_identityunnecessary map of the identity function
- match_as_refmanual implementation of `Option::as_ref`
- match_single_bindingChecks for useless match that binds to only one value
- needless_arbitrary_self_typethe type of the `self` parameter does not need to be arbitrary
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?