Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::match_single_binding: Checks for useless match that binds to only one value
What it meansChecks for useless match that binds to only one value. It is in the complexity group and warns by default.
Does it matter?
Readability and needless complexity.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
match (a, b) {
(c, d) => {
// useless match
}
}
Write this instead
let (c, d) = (a, b);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::match_single_binding)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
match_single_binding = "allow"One run
cargo clippy -- -A clippy::match-single-bindingThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for useless match that binds to only one value.
Why is this bad?
Readability and needless complexity.
Known problems
Suggested replacements may be incorrect when match
is actually binding temporary value, bringing a ‘dropped while borrowed’ error.
Example
match (a, b) {
(c, d) => {
// useless match
}
}
Use instead:
let (c, d) = (a, b);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- map_identityunnecessary map of the identity function
- map_or_identityexpression can be simplified using `Option::unwrap_or()`
- match_as_refmanual implementation of `Option::as_ref`
- needless_arbitrary_self_typethe type of the `self` parameter does not need to be arbitrary
- needless_as_bytesneedless call to `as_bytes`
- needless_boolChecks for expressions of the form if c { true } else { false } (or vice versa) and suggests using the condition directly
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?