Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::needless_splitn: unnecessary use of `splitn`
What it meansChecks for usage of str::splitn (or str::rsplitn) where using str::split would be the same. It is in the complexity group and warns by default.
What you see
warning: unnecessary use of `splitn` --> main.rs:4:9 | 4 | let _ = str.splitn(3, '=').next().unwrap(); | ^^^^^^^^^^^^^^^^^^ help: try: `str.split('=')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#needless_splitn = note: `#[warn(clippy::needless_splitn)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
The function split is simpler and there is no performance difference in these cases, considering that both functions return a lazy iterator.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let str = "key=value=add";
let _ = str.splitn(3, '=').next().unwrap();
Write this instead
let str = "key=value=add";
let _ = str.split('=').next().unwrap();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::needless_splitn)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
needless_splitn = "allow"One run
cargo clippy -- -A clippy::needless-splitnThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of str::splitn (or str::rsplitn) where using str::split would be the same.
Why is this bad?
The function split is simpler and there is no performance difference in these cases, considering
that both functions return a lazy iterator.
Example
let str = "key=value=add";
let _ = str.splitn(3, '=').next().unwrap();
Use instead:
let str = "key=value=add";
let _ = str.split('=').next().unwrap();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- needless_option_as_derefderefed type is same as origin
- needless_option_takecalled `Option::take()` on a temporary value
- needless_question_markSuggests replacing Ok(x?) or Some(x?) with x in return positions where the ? operator is not needed to convert the type of x
- needless_updateChecks for needlessly including a base struct on update when all fields are changed anyway. This lint is not applied to structs marked with non_exhaustive
- neg_cmp_op_on_partial_ordthe use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable
- no_effectstatement with no effect
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?