Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::neg_cmp_op_on_partial_ord: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable
What it meansChecks for the usage of negated comparison operators on types which only implement PartialOrd (e.g., f64). It is in the complexity group and warns by default.
What you see
warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable --> main.rs:6:25 | 6 | let not_less_or_equal = !(a <= b); | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#neg_cmp_op_on_partial_ord = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
These operators make it easy to forget that the underlying types actually allow not only three potential Orderings (Less, Equal, Greater) but also a fourth one (Uncomparable). This is especially easy to miss if the operator based comparison result is negated.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
let a = 1.0;
let b = f64::NAN;
let not_less_or_equal = !(a <= b);
Write this instead
use std::cmp::Ordering;
let _not_less_or_equal = match a.partial_cmp(&b) {
None | Some(Ordering::Greater) => true,
_ => false,
};
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::neg_cmp_op_on_partial_ord)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
neg_cmp_op_on_partial_ord = "allow"One run
cargo clippy -- -A clippy::neg-cmp-op-on-partial-ordThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for the usage of negated comparison operators on types which only implement
PartialOrd (e.g., f64).
Why is this bad?
These operators make it easy to forget that the underlying types actually allow not only three potential Orderings (Less, Equal, Greater) but also a fourth one (Uncomparable). This is especially easy to miss if the operator based comparison result is negated.
Example
let a = 1.0;
let b = f64::NAN;
let not_less_or_equal = !(a <= b);
Use instead:
use std::cmp::Ordering;
let _not_less_or_equal = match a.partial_cmp(&b) {
None | Some(Ordering::Greater) => true,
_ => false,
};
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- needless_question_markSuggests replacing Ok(x?) or Some(x?) with x in return positions where the ? operator is not needed to convert the type of x
- needless_splitnunnecessary use of `splitn`
- needless_updateChecks for needlessly including a base struct on update when all fields are changed anyway. This lint is not applied to structs marked with non_exhaustive
- no_effectstatement with no effect
- nonnull_unchecked_on_box_ptruse of `NonNull::new_unchecked` with `Box::into_raw`
- only_used_in_recursionparameter is only used in recursion
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?