Email me

Clippy lints / Style

Clippy lint · Style · checked with Clippy 0.1.99

clippy::obfuscated_if_else: this method chain can be written more clearly with `if .. else ..`

What it meansChecks for unnecessary method chains that can be simplified into if .. else ... It is in the style group and warns by default.

What you see

warning: this method chain can be written more clearly with `if .. else ..`
 --> main.rs:4:1
  |
4 | x.then_some("a").unwrap_or("b");
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if x { "a" } else { "b" }`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#obfuscated_if_else
  = note: `#[warn(clippy::obfuscated_if_else)]` on by default

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

This can be written more clearly with if .. else ..

Code that works but is not idiomatic Rust. Warns by default.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

let x = true;
x.then_some("a").unwrap_or("b");

Write this instead

let x = true;
if x { "a" } else { "b" };

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::obfuscated_if_else)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
obfuscated_if_else = "allow"

One run

cargo clippy -- -A clippy::obfuscated-if-else

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Stylegroup
warndefault level
yesfixed by cargo clippy --fix
1.64.0added in Rust

Clippy's own documentation

What it does

Checks for unnecessary method chains that can be simplified into if .. else ...

Why is this bad?

This can be written more clearly with if .. else ..

Limitations

This lint currently only looks for usages of .{then, then_some}(..).{unwrap_or, unwrap_or_else, unwrap_or_default}(..), but will be expanded to account for similar patterns.

Example

let x = true;
x.then_some("a").unwrap_or("b");

Use instead:

let x = true;
if x { "a" } else { "b" };

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Related lints

All 847 Clippy lints · Rust compiler errors · Cargo.toml checker

Up next

Related lintclippy::needless_returnunneeded `return` statementRead it next →

Did this answer your question?

Get the receipts by email.

What my AI agents tried this week, with the real numbers: what worked, what flopped, what made money. One email when there is something worth reading.

No spam, never sold. Every email has a one-click unsubscribe.

Popular in the shop

All 124 tools →

Browse: Bundles and kitsHome, family and schoolMoney and businessAI toolsSports and fitnessMaking and hobbiesFood and drinkIndie dev and launchTrading and quant

Free: Landing page teardown iPhone app cost calculator LLM API cost calculator Paid online: $49 Launch Check App builds Articles FAQ