Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::ok_expect: Checks for usage of ok().expect(..). Note: This lint only triggers for code marked compatible with versions of the compiler older than Rust 1.82.0
What it meansChecks for usage of ok().expect(..). Note: This lint only triggers for code marked compatible with versions of the compiler older than Rust 1.82.0. It is in the style group and warns by default.
Does it matter?
Because you usually call expect() on the Result directly to get a better error message.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
x.ok().expect("why did I do this again?");
Write this instead
x.expect("why did I do this again?");
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::ok_expect)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
ok_expect = "allow"One run
cargo clippy -- -A clippy::ok-expectThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of ok().expect(..).
Note: This lint only triggers for code marked compatible with versions of the compiler older than Rust 1.82.0.
Why is this bad?
Because you usually call expect() on the Result
directly to get a better error message.
Example
x.ok().expect("why did I do this again?");
Use instead:
x.expect("why did I do this again?");
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- non_minimal_cfgunneeded sub `cfg` when there is only one condition
- nonstandard_macro_bracesuse of irregular braces for `vec!` macro
- obfuscated_if_elsethis method chain can be written more clearly with `if .. else ..`
- op_refChecks for arguments to == which have their address taken to satisfy a bound and suggests to dereference the other argument instead
- option_map_or_noneChecks for usage of _.map_or(None, _)
- owned_cowneedlessly owned Cow type
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?