Clippy lint · Restriction · checked with Clippy 0.1.99

clippy::pathbuf_init_then_push: Checks for calls to push immediately after creating a new PathBuf

What it meansChecks for calls to push immediately after creating a new PathBuf. It is in the restriction group and off by default.

Does it matter?

Multiple .join() calls are usually easier to read than multiple .push calls across multiple statements. It might also be possible to use PathBuf::from instead.

Lints that forbid language features for specific codebases (no unwrap, no indexing...). Off by default; pick them one by one, never the whole group.

How to fix it

Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:

Flagged

let mut path_buf = PathBuf::new();
path_buf.push("foo");

Write this instead

let path_buf = PathBuf::from("foo");
// or
let path_buf = PathBuf::new().join("foo");

Turn it off, or on

It is off by default. To use it, set it to warn or deny:

Whole crate (Cargo.toml)

[lints.clippy]
pathbuf_init_then_push = "warn"

In code

#![warn(clippy::pathbuf_init_then_push)]

One run

cargo clippy -- -W clippy::pathbuf-init-then-push

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Restrictiongroup

allowdefault level

nofixed by cargo clippy --fix

1.82.0added in Rust

Clippy's own documentation

What it does

Checks for calls to push immediately after creating a new PathBuf.

Why is this bad?

Multiple .join() calls are usually easier to read than multiple .push calls across multiple statements. It might also be possible to use PathBuf::from instead.

Known problems

.join() introduces an implicit clone(). PathBuf::from can alternatively be used when the PathBuf is newly constructed. This will avoid the implicit clone.

Example

let mut path_buf = PathBuf::new();
path_buf.push("foo");

Use instead:

let path_buf = PathBuf::from("foo");
// or
let path_buf = PathBuf::new().join("foo");

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Up next

Also worth your time

Did this answer your question?