Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::ptr_eq: use `std::ptr::eq` when comparing raw pointers
What it meansUse std::ptr::eq when applicable It is in the style group and warns by default.
What you see
warning: use `std::ptr::eq` when comparing raw pointers --> main.rs:6:9 | 6 | assert!(a as *const _ as usize == b as *const _ as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(a, b)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#ptr_eq = note: `#[warn(clippy::ptr_eq)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
ptr::eq can be used to compare &T references (which coerce to *const T implicitly) by their address rather than comparing the values they point to.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let a = &[1, 2, 3];
let b = &[1, 2, 3];
assert!(a as *const _ as usize == b as *const _ as usize);
Write this instead
let a = &[1, 2, 3];
let b = &[1, 2, 3];
assert!(std::ptr::eq(a, b));
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::ptr_eq)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
ptr_eq = "allow"One run
cargo clippy -- -A clippy::ptr-eqThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Use std::ptr::eq when applicable
Why is this bad?
ptr::eq can be used to compare &T references
(which coerce to *const T implicitly) by their address rather than
comparing the values they point to.
Example
let a = &[1, 2, 3];
let b = &[1, 2, 3];
assert!(a as *const _ as usize == b as *const _ as usize);
Use instead:
let a = &[1, 2, 3];
let b = &[1, 2, 3];
assert!(std::ptr::eq(a, b));
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- print_with_newlineThis lint warns when you use print!() with a format string that ends in a newline
- println_empty_stringempty string literal in `println!`
- ptr_argThis lint checks for function arguments of type &String, &Vec, &PathBuf, and Cow<_>
- question_markChecks for expressions that could be replaced by the ? operator
- redundant_closureChecks for closures which just call another function where the function can be called directly
- redundant_field_namesredundant field names in struct initialization
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?