Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::redundant_field_names: redundant field names in struct initialization
What it meansChecks for fields in struct literals where shorthands could be used. It is in the style group and warns by default.
What you see
warning: redundant field names in struct initialization --> main.rs:9:17 | 9 | let foo = Foo { bar: bar }; | ^^^^^^^^ help: replace it with: `bar` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
If the field and variable names are the same, the field name is redundant.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let bar: u8 = 123;
struct Foo {
bar: u8,
}
let foo = Foo { bar: bar };
Write this instead
let foo = Foo { bar };
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::redundant_field_names)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
redundant_field_names = "allow"One run
cargo clippy -- -A clippy::redundant-field-namesThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
What it does
Checks for fields in struct literals where shorthands could be used.
Why is this bad?
If the field and variable names are the same, the field name is redundant.
Example
let bar: u8 = 123;
struct Foo {
bar: u8,
}
let foo = Foo { bar: bar };
the last line can be simplified to
let foo = Foo { bar };
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- ptr_equse `std::ptr::eq` when comparing raw pointers
- question_markChecks for expressions that could be replaced by the ? operator
- redundant_closureChecks for closures which just call another function where the function can be called directly
- redundant_patternthe `y @ _` pattern can be written as just `y`
- redundant_pattern_matchingLint for redundant pattern matching over Result, Option, std::task::Poll, std::net::IpAddr or bools
- redundant_static_lifetimesconstants have by default a `'static` lifetime
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?