Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::self_named_constructors: constructor `foo` has the same name as the type
What it meansWarns when constructors have the same name as their types. It is in the style group and warns by default.
What you see
warning: constructor `foo` has the same name as the type --> main.rs:6:5 | 6 | / pub fn foo() -> Foo { 7 | | Foo {} 8 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#self_named_constructors = note: `#[warn(clippy::self_named_constructors)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Repeating the name of the type is redundant.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
struct Foo {}
impl Foo {
pub fn foo() -> Foo {
Foo {}
}
}
Write this instead
struct Foo {}
impl Foo {
pub fn new() -> Foo {
Foo {}
}
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::self_named_constructors)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
self_named_constructors = "allow"One run
cargo clippy -- -A clippy::self-named-constructorsThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Warns when constructors have the same name as their types.
Why is this bad?
Repeating the name of the type is redundant.
Example
struct Foo {}
impl Foo {
pub fn foo() -> Foo {
Foo {}
}
}
Use instead:
struct Foo {}
impl Foo {
pub fn new() -> Foo {
Foo {}
}
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- result_map_or_into_optionChecks for usage of _.map_or(None, Some)
- result_unit_errthis returns a `Result<_, ()>`
- same_item_pushit looks like the same item is being pushed into this `Vec`
- should_implement_traitChecks for methods that should live in a trait implementation of a std trait (see llogiq’s blog post for further information) instead of an inherent implementation
- single_char_add_strWarns when using push_str/insert_str with a single-character string literal where push/insert with a char would work fine
- single_component_path_importsthis import is redundant
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?